qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitc...@apache.org
Subject [2/3] qpid-proton git commit: PROTON-1280: Fix Messenger Selectable test - I hate this kind of fix! - We now have a very short time out in select instead of 0 timeout (polling behaviour) so that we don't finish if it takes a little time to receive an
Date Thu, 11 Aug 2016 16:10:29 GMT
PROTON-1280: Fix Messenger Selectable test
- I hate this kind of fix!
- We now have a very short time out in select instead of 0 timeout
  (polling behaviour) so that we don't finish if it takes a little time to
  receive an end of stream on one of our sockets.
- It seems that on Linux you reliably get the end of stream on the select()
  call immediately after closing the socket at the other end locally
- But on FreeBSD you usually don't get the EOS immediately, you need to enter
  the kernel first: this was causing the test to fail on FreeBSD.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/486d8857
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/486d8857
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/486d8857

Branch: refs/heads/master
Commit: 486d88576d81d5d12751e2c9096c49152127bf79
Parents: a313452
Author: Andrew Stitcher <astitcher@apache.org>
Authored: Tue Aug 9 06:37:10 2016 -0400
Committer: Andrew Stitcher <astitcher@apache.org>
Committed: Thu Aug 11 12:09:52 2016 -0400

----------------------------------------------------------------------
 tests/python/proton_tests/messenger.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/486d8857/tests/python/proton_tests/messenger.py
----------------------------------------------------------------------
diff --git a/tests/python/proton_tests/messenger.py b/tests/python/proton_tests/messenger.py
index f4f7233..8da068e 100644
--- a/tests/python/proton_tests/messenger.py
+++ b/tests/python/proton_tests/messenger.py
@@ -974,7 +974,7 @@ class Pump:
         if sel.writing:
           writing.append(sel)
 
-    readable, writable, _ = select(reading, writing, [], 0)
+    readable, writable, _ = select(reading, writing, [], 0.1)
 
     count = 0
     for s in readable:
@@ -988,7 +988,6 @@ class Pump:
   def pump(self):
     while self.pump_once(): pass
 
-
 class SelectableMessengerTest(common.Test):
 
   def testSelectable(self, count = 1):


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message