qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acon...@apache.org
Subject qpid-proton git commit: NO-JIRA: c++ binding: remove incorrect messaging_handler events.
Date Fri, 09 Oct 2015 11:46:15 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master 4f6d9fb53 -> 8112f5f09


NO-JIRA: c++ binding: remove incorrect messaging_handler events.

Removed on_abort, on_commit, on_fetch and on_quit. They are not messaging events,
they are example application events from the python tx_recv_interactive example that
were mistakenly added to the handler.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/8112f5f0
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/8112f5f0
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/8112f5f0

Branch: refs/heads/master
Commit: 8112f5f09515d611c1bea9bce8256516cb5845e9
Parents: 4f6d9fb
Author: Alan Conway <aconway@redhat.com>
Authored: Fri Oct 9 07:32:52 2015 -0400
Committer: Alan Conway <aconway@redhat.com>
Committed: Fri Oct 9 07:42:44 2015 -0400

----------------------------------------------------------------------
 proton-c/bindings/cpp/include/proton/messaging_handler.hpp | 4 ----
 proton-c/bindings/cpp/src/messaging_handler.cpp            | 4 ----
 2 files changed, 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/8112f5f0/proton-c/bindings/cpp/include/proton/messaging_handler.hpp
----------------------------------------------------------------------
diff --git a/proton-c/bindings/cpp/include/proton/messaging_handler.hpp b/proton-c/bindings/cpp/include/proton/messaging_handler.hpp
index af5d78b..e19739e 100644
--- a/proton-c/bindings/cpp/include/proton/messaging_handler.hpp
+++ b/proton-c/bindings/cpp/include/proton/messaging_handler.hpp
@@ -51,16 +51,13 @@ class messaging_handler : public proton_handler
 
     ///@name Over-ride these member functions to handle events
     ///@{
-    PN_CPP_EXTERN virtual void on_abort(event &e);
     PN_CPP_EXTERN virtual void on_accepted(event &e);
-    PN_CPP_EXTERN virtual void on_commit(event &e);
     PN_CPP_EXTERN virtual void on_connection_closed(event &e);
     PN_CPP_EXTERN virtual void on_connection_closing(event &e);
     PN_CPP_EXTERN virtual void on_connection_error(event &e);
     PN_CPP_EXTERN virtual void on_connection_opening(event &e);
     PN_CPP_EXTERN virtual void on_connection_opened(event &e);
     PN_CPP_EXTERN virtual void on_disconnected(event &e);
-    PN_CPP_EXTERN virtual void on_fetch(event &e);
     PN_CPP_EXTERN virtual void on_id_loaded(event &e);
     PN_CPP_EXTERN virtual void on_link_closed(event &e);
     PN_CPP_EXTERN virtual void on_link_closing(event &e);
@@ -68,7 +65,6 @@ class messaging_handler : public proton_handler
     PN_CPP_EXTERN virtual void on_link_opened(event &e);
     PN_CPP_EXTERN virtual void on_link_opening(event &e);
     PN_CPP_EXTERN virtual void on_message(event &e);
-    PN_CPP_EXTERN virtual void on_quit(event &e);
     PN_CPP_EXTERN virtual void on_record_inserted(event &e);
     PN_CPP_EXTERN virtual void on_records_loaded(event &e);
     PN_CPP_EXTERN virtual void on_rejected(event &e);

http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/8112f5f0/proton-c/bindings/cpp/src/messaging_handler.cpp
----------------------------------------------------------------------
diff --git a/proton-c/bindings/cpp/src/messaging_handler.cpp b/proton-c/bindings/cpp/src/messaging_handler.cpp
index d8b0262..cd580f4 100644
--- a/proton-c/bindings/cpp/src/messaging_handler.cpp
+++ b/proton-c/bindings/cpp/src/messaging_handler.cpp
@@ -81,16 +81,13 @@ void messaging_handler::create_helpers() {
 
 messaging_handler::~messaging_handler(){}
 
-void messaging_handler::on_abort(event &e) { on_unhandled(e); }
 void messaging_handler::on_accepted(event &e) { on_unhandled(e); }
-void messaging_handler::on_commit(event &e) { on_unhandled(e); }
 void messaging_handler::on_connection_closed(event &e) { on_unhandled(e); }
 void messaging_handler::on_connection_closing(event &e) { on_unhandled(e); }
 void messaging_handler::on_connection_error(event &e) { on_unhandled(e); }
 void messaging_handler::on_connection_opened(event &e) { on_unhandled(e); }
 void messaging_handler::on_connection_opening(event &e) { on_unhandled(e); }
 void messaging_handler::on_disconnected(event &e) { on_unhandled(e); }
-void messaging_handler::on_fetch(event &e) { on_unhandled(e); }
 void messaging_handler::on_id_loaded(event &e) { on_unhandled(e); }
 void messaging_handler::on_link_closed(event &e) { on_unhandled(e); }
 void messaging_handler::on_link_closing(event &e) { on_unhandled(e); }
@@ -98,7 +95,6 @@ void messaging_handler::on_link_error(event &e) { on_unhandled(e); }
 void messaging_handler::on_link_opened(event &e) { on_unhandled(e); }
 void messaging_handler::on_link_opening(event &e) { on_unhandled(e); }
 void messaging_handler::on_message(event &e) { on_unhandled(e); }
-void messaging_handler::on_quit(event &e) { on_unhandled(e); }
 void messaging_handler::on_record_inserted(event &e) { on_unhandled(e); }
 void messaging_handler::on_records_loaded(event &e) { on_unhandled(e); }
 void messaging_handler::on_rejected(event &e) { on_unhandled(e); }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message