qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rob...@apache.org
Subject qpid-jms git commit: QPIDJMS-105: tweak the asssertion/failure messages for clarity
Date Wed, 07 Oct 2015 16:33:22 GMT
Repository: qpid-jms
Updated Branches:
  refs/heads/master 2ecb1a121 -> f9707240d


QPIDJMS-105: tweak the asssertion/failure messages for clarity


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/f9707240
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/f9707240
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/f9707240

Branch: refs/heads/master
Commit: f9707240dffe23db093a0b632a2d11f3140a8938
Parents: 2ecb1a1
Author: Robert Gemmell <robbie@apache.org>
Authored: Wed Oct 7 17:32:40 2015 +0100
Committer: Robert Gemmell <robbie@apache.org>
Committed: Wed Oct 7 17:32:40 2015 +0100

----------------------------------------------------------------------
 .../jms/integration/ConnectionFactoryIntegrationTest.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/f9707240/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConnectionFactoryIntegrationTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConnectionFactoryIntegrationTest.java
b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConnectionFactoryIntegrationTest.java
index 97ccc67..d72d521 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConnectionFactoryIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConnectionFactoryIntegrationTest.java
@@ -103,9 +103,9 @@ public class ConnectionFactoryIntegrationTest extends QpidJmsTestCase
{
             String uri = "amqp://127.0.0.1:" + testPeer.getServerPort() + "?jms.messageIDType=UNKNOWN";
             try {
                 new JmsConnectionFactory(uri);
-                fail("Should not be able to create a factory with invalid option.");
+                fail("Should not be able to create a factory with invalid id type option
value.");
             } catch (Exception ex) {
-                LOG.debug("Caught error on invalid message ID format: {}", ex);
+                LOG.debug("Caught expected exception on invalid message ID format: {}", ex);
             }
         }
     }
@@ -119,7 +119,7 @@ public class ConnectionFactoryIntegrationTest extends QpidJmsTestCase
{
                 JmsConnectionFactory factory = new JmsConnectionFactory(uri);
                 assertEquals(JmsMessageIDBuilder.BUILTIN.UUID.name(), factory.getMessageIDType());
             } catch (Exception ex) {
-                fail("Should not be able to create a factory with invalid option.");
+                fail("Should have succeeded in creating factory");
             }
 
             try {
@@ -127,7 +127,7 @@ public class ConnectionFactoryIntegrationTest extends QpidJmsTestCase
{
                 JmsConnectionFactory factory = new JmsConnectionFactory(uri);
                 assertEquals(JmsMessageIDBuilder.BUILTIN.UUID.name(), factory.getMessageIDType());
             } catch (Exception ex) {
-                fail("Should not be able to create a factory with invalid option.");
+                fail("Should have succeeded in creating factory");
             }
         }
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message