qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rob...@apache.org
Subject [2/3] qpid-jms git commit: QPIDJMS-91: enable a previously skipped test, now works with 5.12
Date Wed, 12 Aug 2015 14:13:58 GMT
QPIDJMS-91: enable a previously skipped test, now works with 5.12


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/896cfe27
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/896cfe27
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/896cfe27

Branch: refs/heads/master
Commit: 896cfe279b53645776970518f4fc36145a2ff323
Parents: 50ea015
Author: Robert Gemmell <robbie@apache.org>
Authored: Wed Aug 12 14:57:05 2015 +0100
Committer: Robert Gemmell <robbie@apache.org>
Committed: Wed Aug 12 15:08:24 2015 +0100

----------------------------------------------------------------------
 .../qpid/jms/destinations/JmsTemporaryTopicTest.java  | 14 --------------
 1 file changed, 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/896cfe27/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/destinations/JmsTemporaryTopicTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/destinations/JmsTemporaryTopicTest.java
b/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/destinations/JmsTemporaryTopicTest.java
index ec5dac9..83121d3 100644
--- a/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/destinations/JmsTemporaryTopicTest.java
+++ b/qpid-jms-interop-tests/qpid-jms-activemq-tests/src/test/java/org/apache/qpid/jms/destinations/JmsTemporaryTopicTest.java
@@ -30,7 +30,6 @@ import javax.jms.Session;
 import javax.jms.TemporaryTopic;
 
 import org.apache.qpid.jms.support.AmqpTestSupport;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -42,7 +41,6 @@ public class JmsTemporaryTopicTest extends AmqpTestSupport {
 
     protected static final Logger LOG = LoggerFactory.getLogger(JmsTemporaryTopicTest.class);
 
-    @Ignore //TODO: enable and remove "testCreateTemporaryTopicWithoutBrokerCheck"
     @Test(timeout = 60000)
     public void testCreateTemporaryTopic() throws Exception {
         connection = createAmqpConnection();
@@ -53,22 +51,10 @@ public class JmsTemporaryTopicTest extends AmqpTestSupport {
         TemporaryTopic topic = session.createTemporaryTopic();
         session.createConsumer(topic);
 
-        //TODO: TempTopics not yet supported on the Broker, it is faking it, this check fails.
         assertEquals(1, brokerService.getAdminView().getTemporaryTopics().length);
     }
 
     @Test(timeout = 60000)
-    public void testCreateTemporaryTopicWithoutBrokerCheck() throws Exception {
-        connection = createAmqpConnection();
-        connection.start();
-
-        Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
-        assertNotNull(session);
-        TemporaryTopic topic = session.createTemporaryTopic();
-        session.createConsumer(topic);
-    }
-
-    @Test(timeout = 60000)
     public void testCantConsumeFromTemporaryTopicCreatedOnAnotherConnection() throws Exception
{
         connection = createAmqpConnection();
         connection.start();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message