qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject qpid-proton git commit: PROTON-757: stop transport errs printing to stderr
Date Tue, 03 Feb 2015 21:27:40 GMT
Repository: qpid-proton
Updated Branches:
  refs/heads/master d463882d9 -> 78e54ee7d


PROTON-757: stop transport errs printing to stderr

This looks to be since e5696c19 - pn_do_error already sets the
transport->condition fields which are accessible as a pn_error from
pn_transport_error, so we shouldn't really output them to stderr unless
tracing is enabled.


Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/78e54ee7
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/78e54ee7
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/78e54ee7

Branch: refs/heads/master
Commit: 78e54ee7d108dc3e37c663afdecde18525f6b1cd
Parents: d463882
Author: Dominic Evans <dominic.evans@uk.ibm.com>
Authored: Tue Nov 25 09:45:00 2014 +0000
Committer: Dominic Evans <dominic.evans@uk.ibm.com>
Committed: Tue Feb 3 21:04:14 2015 +0000

----------------------------------------------------------------------
 proton-c/src/transport/transport.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/78e54ee7/proton-c/src/transport/transport.c
----------------------------------------------------------------------
diff --git a/proton-c/src/transport/transport.c b/proton-c/src/transport/transport.c
index c75efe2..86b35f8 100644
--- a/proton-c/src/transport/transport.c
+++ b/proton-c/src/transport/transport.c
@@ -908,7 +908,9 @@ int pn_do_error(pn_transport_t *transport, const char *condition, const
char *fm
   pn_condition_set_description(&transport->condition, buf);
   pn_collector_t *collector = pni_transport_collector(transport);
   pn_collector_put(collector, PN_OBJECT, transport, PN_TRANSPORT_ERROR);
-  pn_transport_logf(transport, "ERROR %s %s", condition, buf);
+  if (transport->trace & PN_TRACE_DRV) {
+    pn_transport_logf(transport, "ERROR %s %s", condition, buf);
+  }
   transport->done_processing = true;
   pni_close_tail(transport);
   return PN_ERR;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message