qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rgodf...@apache.org
Subject svn commit: r1573593 - in /qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server: model/Queue.java model/adapter/AbstractConfiguredObject.java model/adapter/AmqpPortAdapter.java queue/AbstractQueue.java
Date Mon, 03 Mar 2014 16:15:57 GMT
Author: rgodfrey
Date: Mon Mar  3 16:15:56 2014
New Revision: 1573593

URL: http://svn.apache.org/r1573593
Log:
QPID-5578 : Addressed review comments from Robbie Gemmell

Modified:
    qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/Queue.java
    qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AbstractConfiguredObject.java
    qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AmqpPortAdapter.java
    qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java

Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/Queue.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/Queue.java?rev=1573593&r1=1573592&r2=1573593&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/Queue.java
(original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/Queue.java
Mon Mar  3 16:15:56 2014
@@ -84,7 +84,7 @@ public interface Queue<X extends Queue<X
 
     // TODO - this should either be a boolean or maybe an enum
     @ManagedAttribute
-    int getMessageGroupSharedGroups();
+    boolean isMessageGroupSharedGroups();
 
 
     @ManagedAttribute
@@ -132,18 +132,6 @@ public interface Queue<X extends Queue<X
     void setNotificationListener(QueueNotificationListener listener);
 
     @ManagedStatistic
-    long getBytesIn();
-
-    @ManagedStatistic
-    long getBytesOut();
-
-    @ManagedStatistic
-    long getMessagesIn();
-
-    @ManagedStatistic
-    long getMessagesOut();
-
-    @ManagedStatistic
     int getBindingCount();
 
     @ManagedStatistic

Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AbstractConfiguredObject.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AbstractConfiguredObject.java?rev=1573593&r1=1573592&r2=1573593&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AbstractConfiguredObject.java
(original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AbstractConfiguredObject.java
Mon Mar  3 16:15:56 2014
@@ -934,7 +934,7 @@ public abstract class AbstractConfigured
             }
             else
             {
-                throw new IllegalArgumentException("Cannot convert type " + value.getClass()
+ " to an Integer");
+                throw new IllegalArgumentException("Cannot convert type " + value.getClass()
+ " to a Short");
             }
         }
     };

Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AmqpPortAdapter.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AmqpPortAdapter.java?rev=1573593&r1=1573592&r2=1573593&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AmqpPortAdapter.java
(original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/model/adapter/AmqpPortAdapter.java
Mon Mar  3 16:15:56 2014
@@ -202,33 +202,4 @@ public class AmqpPortAdapter extends Por
         return null;
     }
 
-    @Override
-    public boolean isTcpNoDelay()
-    {
-        return false;
-    }
-
-    @Override
-    public int getSendBufferSize()
-    {
-        return 0;
-    }
-
-    @Override
-    public int getReceiveBufferSize()
-    {
-        return 0;
-    }
-
-    @Override
-    public boolean getNeedClientAuth()
-    {
-        return false;
-    }
-
-    @Override
-    public boolean getWantClientAuth()
-    {
-        return false;
-    }
 }

Modified: qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java?rev=1573593&r1=1573592&r2=1573593&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
(original)
+++ qpid/trunk/qpid/java/broker-core/src/main/java/org/apache/qpid/server/queue/AbstractQueue.java
Mon Mar  3 16:15:56 2014
@@ -2775,9 +2775,9 @@ public abstract class AbstractQueue
     }
 
     @Override
-    public int getMessageGroupSharedGroups()
+    public boolean isMessageGroupSharedGroups()
     {
-        return (Integer) getAttribute(MESSAGE_GROUP_SHARED_GROUPS);
+        return (Boolean) getAttribute(MESSAGE_GROUP_SHARED_GROUPS);
     }
 
 
@@ -2793,29 +2793,6 @@ public abstract class AbstractQueue
         return 0;
     }
 
-    @Override
-    public long getBytesIn()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getBytesOut()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getMessagesIn()
-    {
-        return 0;
-    }
-
-    @Override
-    public long getMessagesOut()
-    {
-        return 0;
-    }
 
     @Override
     public String setName(final String currentName, final String desiredName)



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message