qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oru...@apache.org
Subject svn commit: r1562518 - in /qpid/branches/java-broker-bdb-ha/qpid/java: bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js
Date Wed, 29 Jan 2014 17:36:35 GMT
Author: orudyy
Date: Wed Jan 29 17:36:34 2014
New Revision: 1562518

URL: http://svn.apache.org/r1562518
Log:
QPID-5413: Fix the issue with flickering node rows in the nodes table

Modified:
    qpid/branches/java-broker-bdb-ha/qpid/java/bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js
    qpid/branches/java-broker-bdb-ha/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js

Modified: qpid/branches/java-broker-bdb-ha/qpid/java/bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js
URL: http://svn.apache.org/viewvc/qpid/branches/java-broker-bdb-ha/qpid/java/bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js?rev=1562518&r1=1562517&r2=1562518&view=diff
==============================================================================
--- qpid/branches/java-broker-bdb-ha/qpid/java/bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js
(original)
+++ qpid/branches/java-broker-bdb-ha/qpid/java/bdbstore/src/main/java/resources/js/qpid/management/virtualhost/bdb_ha/show.js
Wed Jan 29 17:36:34 2014
@@ -103,8 +103,10 @@ define(["dojo/_base/xhr",
         this.priorityContainer.style.display="block";
         this.quorumOverrideContainer.style.display="block";
       }
-      this.membersGrid.update(nodes);
-      this.membersGrid.grid._refresh();
+      if (this.membersGrid.update(nodes))
+      {
+        this.membersGrid.grid._refresh();
+      }
     }
   };
 
@@ -154,7 +156,7 @@ define(["dojo/_base/xhr",
             indirectSelection: true
           }
         },
-        EnhancedGrid, false );
+        EnhancedGrid, true );
 
     this.parametersGrid = new UpdatableStore([],
         findNode("parameters", containerNode),
@@ -162,7 +164,7 @@ define(["dojo/_base/xhr",
          { name: 'Name', field: 'name', width: '50%' },
          { name: 'Value', field: 'value', width: '50%' }
         ],
-        null, null, null, false );
+        null, null, null, true );
 
     this.replicationParametersGrid = new UpdatableStore([],
         findNode("replicationParameters", containerNode),
@@ -170,7 +172,7 @@ define(["dojo/_base/xhr",
          { name: 'Name', field: 'name', width: '50%' },
          { name: 'Value', field: 'value', width: '50%' }
         ],
-        null, null, null, false );
+        null, null, null, true );
   }
 
   BDBHA.prototype._initFields = function(nodeFields, containerNode)

Modified: qpid/branches/java-broker-bdb-ha/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js
URL: http://svn.apache.org/viewvc/qpid/branches/java-broker-bdb-ha/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js?rev=1562518&r1=1562517&r2=1562518&view=diff
==============================================================================
--- qpid/branches/java-broker-bdb-ha/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js
(original)
+++ qpid/branches/java-broker-bdb-ha/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/UpdatableStore.js
Wed Jan 29 17:36:34 2014
@@ -89,8 +89,11 @@ define(["qpid/common/util",
                 if(theItem = store.get(data[i].id)) {
                     var modified = !util.equals(theItem, data[i]);
                     if(modified) {
-                        // ... check attributes for updates
-                        store.notify(theItem, data[i].id);
+                        store.put(data[i], {overwrite: true});
+                        if (store instanceof Observable)
+                        {
+                          store.notify(theItem, data[i].id);
+                        }
                         changed = true;
                     }
                 } else {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message