qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kp...@apache.org
Subject svn commit: r1557620 - in /qpid/trunk/qpid/cpp/src/qpid/linearstore: ISSUES journal/RecoveryManager.cpp
Date Sun, 12 Jan 2014 22:41:32 GMT
Author: kpvdr
Date: Sun Jan 12 22:41:32 2014
New Revision: 1557620

URL: http://svn.apache.org/r1557620
Log:
QPID-5473: Recovery where last record in file is truncated (ie spans files), but following
file is uninitialized causes crash

Modified:
    qpid/trunk/qpid/cpp/src/qpid/linearstore/ISSUES
    qpid/trunk/qpid/cpp/src/qpid/linearstore/journal/RecoveryManager.cpp

Modified: qpid/trunk/qpid/cpp/src/qpid/linearstore/ISSUES
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/linearstore/ISSUES?rev=1557620&r1=1557619&r2=1557620&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/linearstore/ISSUES (original)
+++ qpid/trunk/qpid/cpp/src/qpid/linearstore/ISSUES Sun Jan 12 22:41:32 2014
@@ -61,6 +61,8 @@ Current bugs and performance issues:
 7. BZ 1039525 - Crash during recovery - journal::jexception - JERR_JREC_BADRECTAIL
 8. (FIXED) QPID-5442 (BZ 1039949) - DTX test failure - missing XIDs
 9. (FIXED) QPID-5460 (BZ 1051097) - Transactional messages lost during recovery
+10. QPID-5464 - Incompletely created journal files accumulate in EFP
+11. QPID-5473 (BZ 1051924) - Recovery where last record in file is truncated (ie spans files),
but following file is uninitialized causes crash
 
 Code tidy-up
 ------------

Modified: qpid/trunk/qpid/cpp/src/qpid/linearstore/journal/RecoveryManager.cpp
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/linearstore/journal/RecoveryManager.cpp?rev=1557620&r1=1557619&r2=1557620&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/linearstore/journal/RecoveryManager.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/linearstore/journal/RecoveryManager.cpp Sun Jan 12 22:41:32
2014
@@ -456,7 +456,7 @@ void RecoveryManager::checkJournalAlignm
 bool RecoveryManager::decodeRecord(jrec& record,
                                    std::size_t& cumulativeSizeRead,
                                    ::rec_hdr_t& headerRecord,
-                                    std::streampos& fileOffset)
+                                   std::streampos& fileOffset)
 {
     std::streampos start_file_offs = fileOffset;
 
@@ -478,7 +478,6 @@ bool RecoveryManager::decodeRecord(jrec&
         }
         if (!done && needNextFile()) {
             if (!getNextFile(false)) {
-                checkJournalAlignment(start_file_offs);
                 return false;
             }
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message