qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From astitc...@apache.org
Subject svn commit: r1492847 - in /qpid/trunk/qpid/cpp/src/qpid/sys: AsynchIO.h posix/AsynchIO.cpp
Date Thu, 13 Jun 2013 20:19:29 GMT
Author: astitcher
Date: Thu Jun 13 20:19:29 2013
New Revision: 1492847

URL: http://svn.apache.org/r1492847
Log:
NO-JIRA: Remove unnecessary includes for AsynchIO

Modified:
    qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h
    qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp

Modified: qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h?rev=1492847&r1=1492846&r2=1492847&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h (original)
+++ qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h Thu Jun 13 20:19:29 2013
@@ -24,7 +24,6 @@
 #include "qpid/CommonImportExport.h"
 
 #include "qpid/sys/IntegerTypes.h"
-#include "qpid/sys/SecuritySettings.h"
 
 #include <string.h>
 
@@ -33,7 +32,8 @@
 
 namespace qpid {
 namespace sys {
-    
+
+class SecuritySettings;
 class Socket;
 class Poller;
 

Modified: qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp?rev=1492847&r1=1492846&r2=1492847&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp Thu Jun 13 20:19:29 2013
@@ -20,6 +20,7 @@
  */
 
 #include "qpid/sys/AsynchIO.h"
+#include "qpid/sys/SecuritySettings.h"
 #include "qpid/sys/Socket.h"
 #include "qpid/sys/SocketAddress.h"
 #include "qpid/sys/Poller.h"
@@ -28,15 +29,14 @@
 #include "qpid/sys/Time.h"
 #include "qpid/log/Statement.h"
 
-#include "qpid/sys/posix/check.h"
-
 // TODO The basic algorithm here is not really POSIX specific and with a
 // bit more abstraction could (should) be promoted to be platform portable
-#include <unistd.h>
-#include <sys/socket.h>
-#include <signal.h>
+// - The POSIX specific code here is ignoring SIGPIPE which should really
+//   be part of the socket code.
+// - And checking errno to detect specific read/write conditions.
+//
 #include <errno.h>
-#include <string.h>
+#include <signal.h>
 
 #include <boost/bind.hpp>
 #include <boost/lexical_cast.hpp>



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


Mime
View raw message