qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kw...@apache.org
Subject svn commit: r1242338 - in /qpid/trunk/qpid/java: client/src/main/java/org/apache/qpid/client/ systests/src/main/java/org/apache/qpid/test/unit/client/connection/
Date Thu, 09 Feb 2012 14:31:19 GMT
Author: kwall
Date: Thu Feb  9 14:31:19 2012
New Revision: 1242338

URL: http://svn.apache.org/viewvc?rev=1242338&view=rev
Log:
QPID-3819: ExhaustiveACLTests seen to timeout

Backout changes to AMQStateManager made by QPID-3512 as these changes were causing the client
to hang for 30
seconds after the Broker closed connection due to ACL violation.  Refactored ConnectionCloseTest
(now
called BrokerClosesClientConnectionTest) to avoid the sporadic failure by verifying that the
closed connection
is reported correctly to the client.

Added:
    qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/BrokerClosesClientConnectionTest.java
Removed:
    qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ConnectionCloseTest.java
    qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/ExceptionListenerTest.java
Modified:
    qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java

Modified: qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java?rev=1242338&r1=1242337&r2=1242338&view=diff
==============================================================================
--- qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java
(original)
+++ qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionDelegate_8_0.java
Thu Feb  9 14:31:19 2012
@@ -71,30 +71,7 @@ public class AMQConnectionDelegate_8_0 i
 
     public void closeConnection(long timeout) throws JMSException, AMQException
     {
-        final AMQStateManager stateManager = _conn.getProtocolHandler().getStateManager();
-        final AMQState currentState = stateManager.getCurrentState();
-
-        if (currentState.equals(AMQState.CONNECTION_CLOSED))
-        {
-            _logger.debug("Connection already closed.");
-        }
-        else if (currentState.equals(AMQState.CONNECTION_CLOSING))
-        {
-            _logger.debug("Connection already closing, awaiting closed state.");
-            final StateWaiter closeWaiter = new StateWaiter(stateManager, currentState, EnumSet.of(AMQState.CONNECTION_CLOSED));
-            try
-            {
-                closeWaiter.await(timeout);
-            }
-            catch (AMQTimeoutException te)
-            {
-                throw new AMQTimeoutException("Close did not complete in timely fashion",
te);
-            }
-        }
-        else
-        {
-            _conn.getProtocolHandler().closeConnection(timeout);
-        }
+        _conn.getProtocolHandler().closeConnection(timeout);
     }
 
     public AMQConnectionDelegate_8_0(AMQConnection conn)

Added: qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/BrokerClosesClientConnectionTest.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/BrokerClosesClientConnectionTest.java?rev=1242338&view=auto
==============================================================================
--- qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/BrokerClosesClientConnectionTest.java
(added)
+++ qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/client/connection/BrokerClosesClientConnectionTest.java
Thu Feb  9 14:31:19 2012
@@ -0,0 +1,127 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.qpid.test.unit.client.connection;
+
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.qpid.AMQConnectionClosedException;
+import org.apache.qpid.AMQDisconnectedException;
+import org.apache.qpid.management.jmx.ManagedConnectionMBeanTest;
+import org.apache.qpid.test.utils.QpidBrokerTestCase;
+import org.apache.qpid.transport.ConnectionException;
+
+import javax.jms.Connection;
+import javax.jms.ExceptionListener;
+import javax.jms.JMSException;
+import javax.jms.Session;
+
+/**
+ * Tests the behaviour of the client when the Broker terminates client connection
+ * by the Broker being shutdown gracefully or otherwise.
+ *
+ * @see ManagedConnectionMBeanTest
+ */
+public class BrokerClosesClientConnectionTest extends QpidBrokerTestCase
+{
+    private Connection _connection;
+    private boolean _isExternalBroker;
+    private final RecordingExceptionListener _recordingExceptionListener = new RecordingExceptionListener();
+
+    @Override
+    protected void setUp() throws Exception
+    {
+        super.setUp();
+
+        _connection = getConnection();
+        _connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        _connection.setExceptionListener(_recordingExceptionListener);
+
+        _isExternalBroker = isExternalBroker();
+    }
+
+    public void testClientCloseOnNormalBrokerShutdown() throws Exception
+    {
+        final Class<? extends Exception> expectedLinkedException = isBroker010() ?
ConnectionException.class : AMQConnectionClosedException.class;
+
+        stopBroker();
+
+        JMSException exception = _recordingExceptionListener.awaitException(10000);
+        assertConnectionCloseWasReported(exception, expectedLinkedException);
+
+        ensureCanCloseWithoutException();
+    }
+
+    public void testClientCloseOnBrokerKill() throws Exception
+    {
+        final Class<? extends Exception> expectedLinkedException = isBroker010() ?
ConnectionException.class : AMQDisconnectedException.class;
+
+        if (!_isExternalBroker)
+        {
+            return;
+        }
+
+        killBroker();
+
+        JMSException exception = _recordingExceptionListener.awaitException(10000);
+        assertConnectionCloseWasReported(exception, expectedLinkedException);
+
+        ensureCanCloseWithoutException();
+    }
+
+    private void ensureCanCloseWithoutException()
+    {
+        try
+        {
+            _connection.close();
+        }
+        catch (JMSException e)
+        {
+            fail("Connection should close without exception" + e.getMessage());
+        }
+    }
+
+    private void assertConnectionCloseWasReported(JMSException exception, Class<? extends
Exception> linkedExceptionClass)
+    {
+        assertNotNull("Broker shutdown should be reported to the client via the ExceptionListener",
exception);
+        assertNotNull("JMXException should have linked exception", exception.getLinkedException());
+
+        assertEquals("Unexpected linked exception", linkedExceptionClass, exception.getLinkedException().getClass());
+    }
+
+    private final class RecordingExceptionListener implements ExceptionListener
+    {
+        private final CountDownLatch _exceptionReceivedLatch = new CountDownLatch(1);
+        private volatile JMSException _exception;
+
+        @Override
+        public void onException(JMSException exception)
+        {
+            _exception = exception;
+        }
+
+        public JMSException awaitException(long timeoutInMillis) throws InterruptedException
+        {
+            _exceptionReceivedLatch.await(timeoutInMillis, TimeUnit.MILLISECONDS);
+            return _exception;
+        }
+    }
+}



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org


Mime
View raw message