qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tr...@apache.org
Subject svn commit: r1058710 - /qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp
Date Thu, 13 Jan 2011 19:12:00 GMT
Author: tross
Date: Thu Jan 13 19:12:00 2011
New Revision: 1058710

URL: http://svn.apache.org/viewvc?rev=1058710&view=rev
Log:
Originally, when the broker agent authorized a method call, if the message was too large
to fir in the working buffer, the method was rejected.  This change rejects the method only
if there is an ACL configured.

Modified:
    qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp

Modified: qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp?rev=1058710&r1=1058709&r2=1058710&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp Thu Jan 13 19:12:00 2011
@@ -2018,8 +2018,13 @@ bool ManagementAgent::authorizeAgentMess
     string  methodName;
     string cid;
 
+    //
+    // If the message is larger than our working buffer size, we can't determine if it's
+    // authorized or not.  In this case, return true (authorized) if there is no ACL in place,
+    // otherwise return false;
+    //
     if (msg.encodedSize() > MA_BUFFER_SIZE)
-        return false;
+        return broker->getAcl() == 0;
 
     msg.encodeContent(inBuffer);
     uint32_t bufferLen = inBuffer.getPosition();



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org


Mime
View raw message