qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From acon...@apache.org
Subject svn commit: r929272 - /qpid/trunk/qpid/cpp/src/tests/cluster_tests.py
Date Tue, 30 Mar 2010 20:56:53 GMT
Author: aconway
Date: Tue Mar 30 20:56:53 2010
New Revision: 929272

URL: http://svn.apache.org/viewvc?rev=929272&view=rev
Log:
Fix intermittent failure of cluster_tests.py test_last_store_clean.

Modified:
    qpid/trunk/qpid/cpp/src/tests/cluster_tests.py

Modified: qpid/trunk/qpid/cpp/src/tests/cluster_tests.py
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/tests/cluster_tests.py?rev=929272&r1=929271&r2=929272&view=diff
==============================================================================
--- qpid/trunk/qpid/cpp/src/tests/cluster_tests.py (original)
+++ qpid/trunk/qpid/cpp/src/tests/cluster_tests.py Tue Mar 30 20:56:53 2010
@@ -404,12 +404,17 @@ class StoreTests(BrokerTest):
         c = cluster.start("c", expect=EXPECT_EXIT_FAIL)
         a.send_message("q", Message("x", durable=True))
         a.kill()
+        # FIXME aconway 2010-03-29: this test has too many sleeps.
+        # Need to tighten up status persistence to be more atomic and less
+        # prone to interruption.
+        time.sleep(0.1)   # pause for b to update status.
         b.kill()          # c is last man
         time.sleep(0.1)   # pause for c to find out hes last.
         a = cluster.start("a", expect=EXPECT_EXIT_FAIL) # c no longer last man
+        time.sleep(0.1)   # pause for c to find out hes no longer last.
         c.kill()          # a is now last man
         time.sleep(0.1)   # pause for a to find out hes last.
-        a.kill()          # really last
+        a.kill()          # really last, should be clean.
         # b & c should be dirty
         b = cluster.start("b", wait=False, expect=EXPECT_EXIT_FAIL)
         self.assert_dirty_store(b)



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org


Mime
View raw message