Return-Path: Delivered-To: apmail-qpid-commits-archive@www.apache.org Received: (qmail 80598 invoked from network); 4 Sep 2009 09:40:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Sep 2009 09:40:55 -0000 Received: (qmail 88944 invoked by uid 500); 4 Sep 2009 09:40:55 -0000 Delivered-To: apmail-qpid-commits-archive@qpid.apache.org Received: (qmail 88917 invoked by uid 500); 4 Sep 2009 09:40:55 -0000 Mailing-List: contact commits-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@qpid.apache.org Delivered-To: mailing list commits@qpid.apache.org Received: (qmail 88908 invoked by uid 99); 4 Sep 2009 09:40:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2009 09:40:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2009 09:40:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id BE3492388876; Fri, 4 Sep 2009 09:40:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r811326 - in /qpid/branches/java-network-refactor/qpid/java: broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java Date: Fri, 04 Sep 2009 09:40:32 -0000 To: commits@qpid.apache.org From: aidan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090904094032.BE3492388876@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: aidan Date: Fri Sep 4 09:40:32 2009 New Revision: 811326 URL: http://svn.apache.org/viewvc?rev=811326&view=rev Log: QPID-2025: Log errors instead of printStackTracing() Modified: qpid/branches/java-network-refactor/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java qpid/branches/java-network-refactor/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java Modified: qpid/branches/java-network-refactor/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java URL: http://svn.apache.org/viewvc/qpid/branches/java-network-refactor/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java?rev=811326&r1=811325&r2=811326&view=diff ============================================================================== --- qpid/branches/java-network-refactor/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java (original) +++ qpid/branches/java-network-refactor/qpid/java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngine.java Fri Sep 4 09:40:32 2009 @@ -227,7 +227,7 @@ } catch (Exception e) { - e.printStackTrace(); + _logger.error("Unexpected exception when processing datablock", e); closeProtocolSession(); } } @@ -236,7 +236,7 @@ } catch (Exception e) { - e.printStackTrace(); + _logger.error("Unexpected exception when processing datablock", e); closeProtocolSession(); } } Modified: qpid/branches/java-network-refactor/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java URL: http://svn.apache.org/viewvc/qpid/branches/java-network-refactor/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java?rev=811326&r1=811325&r2=811326&view=diff ============================================================================== --- qpid/branches/java-network-refactor/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java (original) +++ qpid/branches/java-network-refactor/qpid/java/common/src/main/java/org/apache/qpid/transport/network/mina/MINANetworkDriver.java Fri Sep 4 09:40:32 2009 @@ -30,13 +30,13 @@ import javax.net.ssl.SSLEngine; +import org.apache.log4j.Logger; import org.apache.mina.common.ConnectFuture; import org.apache.mina.common.IdleStatus; import org.apache.mina.common.IoAcceptor; import org.apache.mina.common.IoFilterChain; import org.apache.mina.common.IoHandlerAdapter; import org.apache.mina.common.IoSession; -import org.apache.mina.common.IoSessionConfig; import org.apache.mina.common.SimpleByteBufferAllocator; import org.apache.mina.common.WriteFuture; import org.apache.mina.filter.ReadThrottleFilterBuilder; @@ -80,6 +80,8 @@ private WriteFuture _lastWriteFuture; + private static final Logger _logger = Logger.getLogger(MINANetworkDriver.class); + public MINANetworkDriver(boolean useNIO, int processors, boolean executorPool, boolean protectIO) { _useNIO = useNIO; @@ -289,6 +291,10 @@ if (_protocolEngine != null) { _protocolEngine.exception(throwable); + } + else + { + _logger.error("Exception thrown and no ProtocolEngine to handle it", throwable); } _lastException = throwable; } --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:commits-subscribe@qpid.apache.org