qpid-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ritch...@apache.org
Subject svn commit: r630730 - /incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java
Date Mon, 25 Feb 2008 03:59:59 GMT
Author: ritchiem
Date: Sun Feb 24 19:59:58 2008
New Revision: 630730

URL: http://svn.apache.org/viewvc?rev=630730&view=rev
Log:
QPID-809 : Added comments and improved logging msgs.

Modified:
    incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java

Modified: incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java
URL: http://svn.apache.org/viewvc/incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java?rev=630730&r1=630729&r2=630730&view=diff
==============================================================================
--- incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java
(original)
+++ incubator/qpid/branches/M2.1/java/client/src/main/java/org/apache/qpid/client/handler/ConnectionCloseMethodHandler.java
Sun Feb 24 19:59:58 2008
@@ -75,8 +75,9 @@
             {
                 if (errorCode == AMQConstant.NOT_ALLOWED || (errorCode == AMQConstant.ACCESS_REFUSED))
                 {
-                    _logger.info("Authentication Error:" + Thread.currentThread().getName());
+                    _logger.info("Error :" + errorCode +":"+ Thread.currentThread().getName());
 
+                    // todo ritchiem : Why do this here when it is going to be done in the
finally block?
                     session.closeProtocolSession();
 
                     // todo this is a bit of a fudge (could be conssidered such as each new
connection needs a new state manager or at least a fresh state.
@@ -98,6 +99,8 @@
 
             session.closeProtocolSession();
 
+            // ritchiem: Doing this though will cause any waiting connection start to be
released without being able to
+            // see what the cause was.
             stateManager.changeState(AMQState.CONNECTION_CLOSED);
         }
     }



Mime
View raw message