pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] gaoran10 opened a new pull request #7856: [Transaction] Handle Acknowledge In The Transaction
Date Thu, 20 Aug 2020 03:01:53 GMT

gaoran10 opened a new pull request #7856:
URL: https://github.com/apache/pulsar/pull/7856


   Fix https://github.com/streamnative/pulsar/issues/1307
   
   Master Issue: #2664 
   
   ### Motivation
   
   Handle acknowledge in the transaction.
   
   ### Modifications
   
   1. Register subscription to the transaction metadata store.
   2. Make the ack command carry the transaction information.
   3. When committing a transaction, commit every subscription in the transaction.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   - *org.apache.pulsar.broker.transaction.TransactionProduceTest.ackCommitTest*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (yes)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding
the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message