pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar-client-go] shohi commented on a change in pull request #323: define logger interface and add Logger field to ClientOptions
Date Mon, 17 Aug 2020 03:18:25 GMT

shohi commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r471198778



##########
File path: pulsar/producer_partition.go
##########
@@ -89,7 +88,7 @@ type partitionProducer struct {
 	state  int32
 	client *client
 	topic  string
-	log    *log.Entry
+	logger log.Logger

Review comment:
       `log` is usually used for the package name, the logger is the one who does the logging
job, i think it's more accurate using `logger` than `log`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message