pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar-client-go] merlimat commented on a change in pull request #323: add Logger field to ClientOptions
Date Fri, 24 Jul 2020 02:16:17 GMT

merlimat commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r459822291



##########
File path: pulsar/client.go
##########
@@ -91,6 +92,9 @@ type ClientOptions struct {
 
 	// Max number of connections to a single broker that will kept in the pool. (Default: 1
connection)
 	MaxConnectionsPerBroker int
+
+	// Configure the logger used by the client. (Default: logrus.StandardLogger())
+	Logger *logrus.Logger

Review comment:
       My main concern is that once we expose in API, people can depend on it. So we should
rather first define the logger API and then apply this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message