pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar-client-go] merlimat commented on a change in pull request #323: add Logger field to ClientOptions
Date Tue, 14 Jul 2020 16:32:26 GMT

merlimat commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r454487155



##########
File path: pulsar/client.go
##########
@@ -91,6 +92,9 @@ type ClientOptions struct {
 
 	// Max number of connections to a single broker that will kept in the pool. (Default: 1
connection)
 	MaxConnectionsPerBroker int
+
+	// Configure the logger used by the client. (Default: logrus.StandardLogger())
+	Logger *logrus.Logger

Review comment:
       I like this approach, though in this case we'd be exposing Logrus as part of our API,
something that we cannot later rollback. 
   
   If we want to take a logger option in, we should have a custom logger interface (with default
impl bound to logrus).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message