pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] Persi commented on a change in pull request #6905: [Issue #6842] feat(schema): allow for schema reader and writer registration on SchemaDefinition
Date Thu, 07 May 2020 16:51:48 GMT

Persi commented on a change in pull request #6905:
URL: https://github.com/apache/pulsar/pull/6905#discussion_r421649519



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/JacksonJsonReader.java
##########
@@ -27,11 +27,11 @@
 import java.io.IOException;
 import java.io.InputStream;
 
-public class JsonReader<T> implements SchemaReader<T> {
+public class JacksonJsonReader<T> implements SchemaReader<T> {

Review comment:
       Well .. yeah someone could have used this class, for whatever reason from outside the
framework. But it's original name is bad chosen, probably keep both and make the old class
deprecated?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message