From commits-return-51044-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Mar 24 07:57:41 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 967A718065C for ; Tue, 24 Mar 2020 08:57:41 +0100 (CET) Received: (qmail 85899 invoked by uid 500); 24 Mar 2020 07:57:41 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 85890 invoked by uid 99); 24 Mar 2020 07:57:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2020 07:57:40 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] bsideup commented on a change in pull request #6512: WIP: [protocol] Grpc protocol handler Message-ID: <158503666087.10251.12558990774572859428.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 24 Mar 2020 07:57:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bsideup commented on a change in pull request #6512: WIP: [protocol] Grpc protocol handler URL: https://github.com/apache/pulsar/pull/6512#discussion_r396959387 ########## File path: pulsar-protocols/grpc/src/main/proto/PulsarApi.proto ########## @@ -0,0 +1,888 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +syntax = "proto2"; + +package pulsar.protocols.grpc; +option java_package = "org.apache.pulsar.protocols.grpc.api"; +option java_multiple_files = true; +// option optimize_for = LITE_RUNTIME; + +service Pulsar { + rpc produce(stream CommandSend) returns (stream SendResult) {} Review comment: note that stream-based `produce` will not be using any load balancing and send messages to the same broker, while single record produce can use gRPC's load balancing underneath. That's exactly the reason why we had it as a single record produce in Liiklus: https://github.com/bsideup/liiklus/blob/e5620a2320811997fe8d09b62db078fdfed9acd4/protocol/src/main/proto/LiiklusService.proto#L13 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services