From commits-return-49980-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Mar 2 19:50:25 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1703B18062C for ; Mon, 2 Mar 2020 20:50:24 +0100 (CET) Received: (qmail 51220 invoked by uid 500); 2 Mar 2020 19:50:24 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 51211 invoked by uid 99); 2 Mar 2020 19:50:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2020 19:50:24 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] sijie commented on a change in pull request #6456: [Issue 6394] Add configuration to disable auto creation of subscriptions Message-ID: <158317862445.24221.13156165322596269242.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 02 Mar 2020 19:50:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #6456: [Issue 6394] Add configuration to disable auto creation of subscriptions URL: https://github.com/apache/pulsar/pull/6456#discussion_r386612851 ########## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceAutoTopicCreationTest.java ########## @@ -104,6 +104,24 @@ public void testAutoTopicCreationDisableIfNonPartitionedTopicAlreadyExist() thro assertTrue(admin.namespaces().getTopics("prop/ns-abc").contains(topicName)); } + @Test + public void testAutoSubscriptionCreationDisable() throws Exception{ Review comment: @murong00 Can you add a test to cover the case - if `allowAutoSubscriptionCreation` is disabled people can still create a subscription using `pulsar-admin`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services