From commits-return-49926-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org  Sun Mar  1 08:52:03 2020
Return-Path: <commits-return-49926-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 12B0618064F
	for <archive-asf-public@cust-asf.ponee.io>; Sun,  1 Mar 2020 09:52:02 +0100 (CET)
Received: (qmail 35689 invoked by uid 500); 1 Mar 2020 08:52:02 -0000
Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pulsar.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pulsar.apache.org>
List-Post: <mailto:commits@pulsar.apache.org>
List-Id: <commits.pulsar.apache.org>
Reply-To: dev@pulsar.apache.org
Delivered-To: mailing list commits@pulsar.apache.org
Received: (qmail 35679 invoked by uid 99); 1 Mar 2020 08:52:02 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Mar 2020 08:52:02 +0000
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] [pulsar] gaoran10 commented on a change in pull request #6445:
 Fixed avro schema decode error in functions
Message-ID: <158305272213.3149.3534354400271747886.gitbox@gitbox.apache.org>
References: <infra.6445.MDExOlB1bGxSZXF1ZXN0MzgxODIzNDEw.gitbox@gitbox.apache.org>
In-Reply-To: <infra.6445.MDExOlB1bGxSZXF1ZXN0MzgxODIzNDEw.gitbox@gitbox.apache.org>
Date: Sun, 01 Mar 2020 08:52:02 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

gaoran10 commented on a change in pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#discussion_r386089300
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
 ##########
 @@ -88,14 +97,19 @@ public boolean supportSchemaVersioning() {
         return new AvroSchema<>(parseSchemaInfo(schemaDefinition, SchemaType.AVRO));
     }
 
+    public static <T> AvroSchema<T> ofWithClass(SchemaDefinition<T> schemaDefinition) {
 
 Review comment:
   Yes, it's more reasonable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services