pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] bsideup commented on a change in pull request #6512: WIP: [protocol] Grpc protocol handler
Date Tue, 24 Mar 2020 07:57:40 GMT
bsideup commented on a change in pull request #6512: WIP: [protocol] Grpc protocol handler
URL: https://github.com/apache/pulsar/pull/6512#discussion_r396959387

 File path: pulsar-protocols/grpc/src/main/proto/PulsarApi.proto
 @@ -0,0 +1,888 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+syntax = "proto2";
+package pulsar.protocols.grpc;
+option java_package = "org.apache.pulsar.protocols.grpc.api";
+option java_multiple_files = true;
+// option optimize_for = LITE_RUNTIME;
+service Pulsar {
+    rpc produce(stream CommandSend) returns (stream SendResult) {}
 Review comment:
   note that stream-based `produce` will not be using any load balancing and send messages
to the same broker, while single record produce can use gRPC's load balancing underneath.
   That's exactly the reason why we had it as a single record produce in Liiklus:

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message