pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request #198: Fix pprof typo
Date Thu, 19 Mar 2020 03:36:59 GMT
wolfstudy commented on a change in pull request #198: Fix pprof typo
URL: https://github.com/apache/pulsar-client-go/pull/198#discussion_r394773235
 
 

 ##########
 File path: perf/pulsar-perf-go.go
 ##########
 @@ -69,6 +70,15 @@ func main() {
 		Use: "pulsar-perf-go",
 	}
 
+	go func() {
 
 Review comment:
   By default, `pprof` does not collect project metrics. So it will not cause any loss in
performance. 
   
   But if we do this, we can provide the user with a `pprof` which is directly accessed by
the browser. What's wrong?
   
   In this way, people who use the pulsar-go-client in the production environment can also
monitor their running status through the browser at all times, instead of collecting each
time through the `go tool pprof`.
   
   > Also, if you run two processes only one server will start. Why is this being added?
   
   Are you sure? When testing in my local environment, we can access it in the browser through
`localhost: 8889`, or we can use `go tool pprof -http=:8081 $HOME/pprof/pprof.samples.cpu.004.pb.gz`
to access.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message