pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #198: Fix pprof typo
Date Wed, 18 Mar 2020 21:17:48 GMT
cckellogg commented on a change in pull request #198: Fix pprof typo
URL: https://github.com/apache/pulsar-client-go/pull/198#discussion_r394642942
 
 

 ##########
 File path: perf/pulsar-perf-go.go
 ##########
 @@ -69,6 +70,15 @@ func main() {
 		Use: "pulsar-perf-go",
 	}
 
+	go func() {
 
 Review comment:
   In my opinion this should not be started by default and should be controlled with a cli
flag. Also, if you run two processes only one server will start. Why is this being added?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message