pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] vzhikserg commented on a change in pull request #6356: Independent schema is set for each consumer generated by topic
Date Mon, 02 Mar 2020 20:38:21 GMT
vzhikserg commented on a change in pull request #6356: Independent schema is set for each consumer
generated by topic
URL: https://github.com/apache/pulsar/pull/6356#discussion_r386636498
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/schema/Schemas.java
 ##########
 @@ -29,36 +29,36 @@
     @NoArgsConstructor
     @AllArgsConstructor
     public static class PersonOne{
-        int id;
+        public int id;
 
 Review comment:
   This class provides all possible constructors and getters/setters for all fields. Please
use them instead of defining fields as public

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message