pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] gaoran10 commented on a change in pull request #6445: Fixed avro schema decode error in functions
Date Sun, 01 Mar 2020 08:52:02 GMT
gaoran10 commented on a change in pull request #6445: Fixed avro schema decode error in functions
URL: https://github.com/apache/pulsar/pull/6445#discussion_r386089300
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
 ##########
 @@ -88,14 +97,19 @@ public boolean supportSchemaVersioning() {
         return new AvroSchema<>(parseSchemaInfo(schemaDefinition, SchemaType.AVRO));
     }
 
+    public static <T> AvroSchema<T> ofWithClass(SchemaDefinition<T> schemaDefinition)
{
 
 Review comment:
   Yes, it's more reasonable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message