pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] codelipenghui commented on a change in pull request #6345: [Java Reader Client] Start reader inside batch result in read first message in batch.
Date Tue, 18 Feb 2020 07:52:59 GMT
codelipenghui commented on a change in pull request #6345: [Java Reader Client] Start reader
inside batch result in read first message in batch.
URL: https://github.com/apache/pulsar/pull/6345#discussion_r380505080
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
 ##########
 @@ -1091,8 +1091,8 @@ private boolean isPriorBatchIndex(long idx) {
         return resetIncludeHead ? idx < startMessageId.getBatchIndex() : idx <= startMessageId.getBatchIndex();
     }
 
-    private boolean isResetIncludedAndSameEntryLedger(MessageIdData messageId) {
-        return !resetIncludeHead && startMessageId != null
+    private boolean isNonDurableAndSameEntryAndLedger(MessageIdData messageId) {
 
 Review comment:
   Due to this method does not only support for non-durable subscription, so is it better
to named `isSameEntry()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message