pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for batch message local index
Date Thu, 13 Feb 2020 22:44:53 GMT
sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for batch message
local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r379153352
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -54,6 +54,7 @@ message MessageIdData {
     required uint64 entryId  = 2;
     optional int32 partition = 3 [default = -1];
     optional int32 batch_index = 4 [default = -1];
+    repeated int64 ackSet = 5;
 
 Review comment:
   why `ackSet` is a `repeated int64`? Can it be an `optional int64`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message