pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add Go Function heartbeat (and gRPC service) for production usage
Date Wed, 15 Jan 2020 15:45:34 GMT
wolfstudy commented on a change in pull request #6031: [Issue 4175] [pulsar-function-go] Add
Go Function heartbeat (and gRPC service) for production usage
URL: https://github.com/apache/pulsar/pull/6031#discussion_r366943004
 
 

 ##########
 File path: pulsar-function-go/pb/doc.go
 ##########
 @@ -17,18 +17,4 @@
 // under the License.
 //
 
-// Package api provides the protocol buffer messages that Pulsar
-// uses for the client/broker wire protocol.
-// See "Pulsar binary protocol specification" for more information.
-// https://pulsar.incubator.apache.org/docs/latest/project/BinaryProtocol/
-//
-// The protocol definition files are part of the main Pulsar source,
-// located within the Pulsar repository at:
-// https://github.com/apache/incubator-pulsar/tree/master/pulsar-common/src/main/proto
-//
-// The generated Go code was created from the source Pulsar files at git:
-//    tag:      v1.18-2614-g548c726b8
-//    revision: 548c726b8e7f0e163b1132c9ada6ba83d6bec572
-//
-// Files generated by the protoc-gen-go program should not be modified.
-package pb
+package api
 
 Review comment:
   please don't remove the comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message