pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] codelipenghui commented on a change in pull request #5809: [Issue:5669] Fix the ledgerID not found cause NPE
Date Mon, 09 Dec 2019 03:34:59 GMT
codelipenghui commented on a change in pull request #5809: [Issue:5669] Fix the ledgerID not
found cause NPE
URL: https://github.com/apache/pulsar/pull/5809#discussion_r355251069
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -1790,8 +1790,13 @@ void updateCursor(ManagedCursorImpl cursor, PositionImpl newPosition)
{
         }
     }
 
-    PositionImpl startReadOperationOnLedger(PositionImpl position) {
-        long ledgerId = ledgers.ceilingKey(position.getLedgerId());
+    PositionImpl startReadOperationOnLedger(PositionImpl position, ReadEntriesCallback callback)
{
 
 Review comment:
   It's better to use OpReadEntry to instead ReadEntriesCallback here, because OpReadEntry
do some work related to mbean recored, if we use ReadEntriesCallback, the mbean info will
become incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message