From commits-return-41443-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Nov 6 23:58:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B92B0180651 for ; Thu, 7 Nov 2019 00:57:59 +0100 (CET) Received: (qmail 63216 invoked by uid 500); 6 Nov 2019 23:57:59 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 63207 invoked by uid 99); 6 Nov 2019 23:57:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2019 23:57:58 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] codelipenghui commented on a change in pull request #5571: Add epoch for connection handler to handle create producer timeout. Message-ID: <157308467884.19595.15442998776873678169.gitbox@gitbox.apache.org> Date: Wed, 06 Nov 2019 23:57:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codelipenghui commented on a change in pull request #5571: Add epoch for connection handler to handle create producer timeout. URL: https://github.com/apache/pulsar/pull/5571#discussion_r343390298 ########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java ########## @@ -139,7 +140,9 @@ public String toString() { @Override public ConcurrentOpenHashSet getProducers() { - return producers; + ConcurrentOpenHashSet result = new ConcurrentOpenHashSet<>(16, 1); Review comment: @sijie i will try change the getProducers method to return a map. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services