From commits-return-40940-apmail-pulsar-commits-archive=pulsar.apache.org@pulsar.apache.org Fri Nov 1 15:15:06 2019 Return-Path: X-Original-To: apmail-pulsar-commits-archive@minotaur.apache.org Delivered-To: apmail-pulsar-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id E412219011 for ; Fri, 1 Nov 2019 15:15:05 +0000 (UTC) Received: (qmail 70148 invoked by uid 500); 1 Nov 2019 15:15:05 -0000 Delivered-To: apmail-pulsar-commits-archive@pulsar.apache.org Received: (qmail 70101 invoked by uid 500); 1 Nov 2019 15:15:05 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 70092 invoked by uid 99); 1 Nov 2019 15:15:05 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2019 15:15:05 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options Message-ID: <157262130523.18880.14869419889913571602.gitbox@gitbox.apache.org> Date: Fri, 01 Nov 2019 15:15:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit addisonj commented on issue #5400: [functions] Allow functions to pass runtime specific options URL: https://github.com/apache/pulsar/pull/5400#issuecomment-548826149 @jerrypeng @sijie I reworked this to account for the changes from #5404, I think it seems pretty reasonable. If you could give another review and let me know if there is anything else you want to see here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services