pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #5716: [Issues 5709]remove the namespace checking
Date Sun, 24 Nov 2019 17:07:38 GMT
sijie commented on a change in pull request #5716: [Issues 5709]remove the namespace checking
URL: https://github.com/apache/pulsar/pull/5716#discussion_r349935108
 
 

 ##########
 File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImplTest.java
 ##########
 @@ -62,4 +69,44 @@ public void testGetStats() throws Exception {
         impl.getStats();
     }
 
+    @Test
+    public void multiTopicsInDifferentNameSpace() throws PulsarClientException {
+        List<String> topics = new ArrayList<>();
+        topics.add("persistent://public/default/MultiTopics1");
+        topics.add("persistent://public/test-multi/MultiTopics2");
+        topics.add("persistent://public/test-multi/MultiTopics3");
+        ClientConfigurationData conf = new ClientConfigurationData();
+        conf.setServiceUrl("pulsar://localhost:6650");
+        conf.setStatsIntervalSeconds(100);
+
+        ThreadFactory threadFactory = new DefaultThreadFactory("client-test-multi", Thread.currentThread().isDaemon());
+        EventLoopGroup eventLoopGroup = EventLoopUtil.newEventLoopGroup(conf.getNumIoThreads(),
threadFactory);
+        ExecutorService listenerExecutor = Executors.newSingleThreadScheduledExecutor(threadFactory);
+        PulsarClientImpl clientImpl = new PulsarClientImpl(conf, eventLoopGroup);
+        ConsumerConfigurationData consumerConfData = new ConsumerConfigurationData();
+        consumerConfData.setTopicNames(Sets.newHashSet(topics));
+
+        Consumer consumer = clientImpl.newConsumer().topics(topics)
+                .subscriptionName("multiTopicSubscription")
+                .messageListener(new MessageListener<byte[]>() {
+                    @Override
+                    public void received(Consumer<byte[]> consumer, Message<byte[]>
msg) {
+                        System.out.println(" Message received:" + new String(msg.getData()));
+                    }
+                })
+                .subscribe();
+
+        Producer<String> producer = clientImpl.newProducer(Schema.STRING)
+                .topic("persistent://public/default/MultiTopics1")
+                .create();
+        Producer<String> producer1 = clientImpl.newProducer(Schema.STRING)
+                .topic("persistent://public/test-multi/MultiTopics2")
+                .create();
+        producer.send("default/MultiTopics1-Message1");
+        producer1.send("test-multi/MultiTopics2-Message1");
+        producer.closeAsync();
 
 Review comment:
   you need add the logic to verify you receive the messages that are produced by producer
and producer1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message