pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #5572: Fix create consumer on partitioned topic while disable topic auto creation.
Date Wed, 20 Nov 2019 17:02:45 GMT
sijie commented on a change in pull request #5572: Fix create consumer on partitioned topic
while disable topic auto creation.
URL: https://github.com/apache/pulsar/pull/5572#discussion_r348630391
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
 ##########
 @@ -394,6 +394,7 @@ protected void internalCreatePartitionedTopic(int numPartitions) {
             String path = ZkAdminPaths.partitionedTopicPath(topicName);
             byte[] data = jsonMapper().writeValueAsBytes(new PartitionedTopicMetadata(numPartitions));
             zkCreateOptimistic(path, data);
+            tryCreatePartitions(numPartitions);
             // we wait for the data to be synced in all quorums and the observers
             Thread.sleep(PARTITIONED_TOPIC_WAIT_SYNC_TIME_MS);
 
 Review comment:
   This is a really bad behavior. We can try to use zookeeper.sync to force the data to be
synced to all quorums.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message