pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] codelipenghui commented on a change in pull request #5571: Add epoch for connection handler to handle create producer timeout.
Date Wed, 06 Nov 2019 23:57:58 GMT
codelipenghui commented on a change in pull request #5571: Add epoch for connection handler
to handle create producer timeout.
URL: https://github.com/apache/pulsar/pull/5571#discussion_r343390298
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
 ##########
 @@ -139,7 +140,9 @@ public String toString() {
 
     @Override
     public ConcurrentOpenHashSet<Producer> getProducers() {
-        return producers;
+        ConcurrentOpenHashSet<Producer> result = new ConcurrentOpenHashSet<>(16,
1);
 
 Review comment:
   @sijie i will try change the getProducers method to return a map.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message