pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] wolfstudy commented on issue #5532: Add subscribe position param for consumer of sink
Date Sun, 03 Nov 2019 03:38:52 GMT
wolfstudy commented on issue #5532: Add subscribe position param for consumer of sink
URL: https://github.com/apache/pulsar/pull/5532#issuecomment-549102357
 
 
   > the change looks good to me. however can you please add unit tests for this?
   
   Yes, the test for this option will be overridden in the existing `testDefaultSerDe` case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message