pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] massakam commented on a change in pull request #5155: [pulsar-broker] Close RateLimiter instance
Date Tue, 10 Sep 2019 03:02:22 GMT
massakam commented on a change in pull request #5155: [pulsar-broker] Close RateLimiter instance
URL: https://github.com/apache/pulsar/pull/5155#discussion_r322534421
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherSingleActiveConsumer.java
 ##########
 @@ -146,4 +147,9 @@ protected void readMoreEntries(Consumer consumer) {
     protected void cancelPendingRead() {
         // No-op
     }
+
+    public CompletableFuture<Void> close() {
+        IS_CLOSED_UPDATER.set(this, TRUE);
+        return disconnectAllConsumers();
 
 Review comment:
   Restored `AbstractDispatcherSingleActiveConsumer#close()`. Only `PersistentDispatcherSingleActiveConsumer`
overrides it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message