pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #5115: Add checkstyle validation and fix style violations in the pulsar client api module
Date Thu, 05 Sep 2019 19:46:35 GMT
sijie commented on a change in pull request #5115: Add checkstyle validation and fix style
violations in the pulsar client api module
URL: https://github.com/apache/pulsar/pull/5115#discussion_r321447891
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/AuthenticationFactory.java
 ##########
 @@ -61,6 +61,7 @@ public static Authentication token(Supplier<String> tokenSupplier)
{
      *            the path to the TLS client private key
      * @return the Authentication object initialized with the TLS credentials
      */
+    @SuppressWarnings("checkstyle:MethodName")
 
 Review comment:
   Use `CHECKSTYLE.OFF` and `CHECKSTYLE.ON` comments.
   
   ```
   // CHECKSTYLE.OFF: MethodName
   ...
   // CHECKSTYLE.ON: MethodName
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message