From commits-return-31922-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Jun 19 02:36:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F1A7418066B for ; Wed, 19 Jun 2019 04:36:47 +0200 (CEST) Received: (qmail 23572 invoked by uid 500); 19 Jun 2019 02:36:47 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 23563 invoked by uid 99); 19 Jun 2019 02:36:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Jun 2019 02:36:47 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] jiazhai commented on a change in pull request #4548: [schema] key/value schema enhancement Message-ID: <156091180739.21328.14381848473523935825.gitbox@gitbox.apache.org> Date: Wed, 19 Jun 2019 02:36:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jiazhai commented on a change in pull request #4548: [schema] key/value schema enhancement URL: https://github.com/apache/pulsar/pull/4548#discussion_r294661892 ########## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ########## @@ -54,6 +55,13 @@ default void validate(byte[] message) { decode(message); } + /** + * {@inheritDoc} + */ + default byte[] write(T message) { Review comment: what is the benefit to have a write method？ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services