pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] codelipenghui opened a new pull request #4517: Fix NPE of ProducerInterceptors
Date Wed, 12 Jun 2019 06:46:38 GMT
codelipenghui opened a new pull request #4517: Fix NPE of ProducerInterceptors
URL: https://github.com/apache/pulsar/pull/4517
 
 
   ### Motivation
   
   Fix NPE of ProducerInterceptors while interceptors throw exceptions.
   
   ### Modifications
   
   Remove messageId when print interceptors error logs.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Create a ProducerInterceptor and throw NullPointException in beforeSend.
   - Client can get the messageId.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message