pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #4435: Introduce batch message container framework and support key based batching container
Date Mon, 10 Jun 2019 01:55:34 GMT
sijie commented on a change in pull request #4435: Introduce batch message container framework
and support key based batching container
URL: https://github.com/apache/pulsar/pull/4435#discussion_r291861396
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
 ##########
 @@ -223,6 +224,13 @@ private ProducerBuilderImpl(PulsarClientImpl client, ProducerConfigurationData
c
         return this;
     }
 
+    @Override
+    public ProducerBuilder<T> batchingContainerBuilder(BatchMessageContainerBuilder
batchingContainerBuilder) {
 
 Review comment:
   Batcher sounds like a better name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message