pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] hellozepp opened a new pull request #4482: [pulsar-client] Client stats on partitioned topics missing some aggregated values
Date Wed, 05 Jun 2019 16:25:55 GMT
hellozepp opened a new pull request #4482: [pulsar-client] Client stats on partitioned topics
missing some aggregated values
URL: https://github.com/apache/pulsar/pull/4482
 
 
   Fixes #4432 
   
   ### Motivation
   In `ProducerStatsRecorderImpl.updateCumulativeStats`,it doesn't aggregate  some aggregated
values. We should return a cumulative value for the multi-partition.
   
   ### Modifications
   
   The "parent" producer of a partitioned topic should have fully populated aggregated stats
from all its "children" producers
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   `This change added tests and can be verified as follows:`
     - Added integration tests for  missing aggregated values (org.apache.pulsar.client.api.PartitionedProducerConsumerStatTest)
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / `no`)
     - The public API: (yes / `no`)
     - The schema: (yes / `no` / don't know)
     - The default values of configurations: (yes / `no`)
     - The wire protocol: (yes / `no`)
     - The rest endpoints: (yes / `no`)
     - The admin cli options: (yes / `no`)
     - Anything that affects deployment: (yes / `no` / don't know)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message