From commits-return-29556-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon May 20 09:11:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1D823180627 for ; Mon, 20 May 2019 11:11:03 +0200 (CEST) Received: (qmail 64829 invoked by uid 500); 20 May 2019 09:11:03 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 64820 invoked by uid 99); 20 May 2019 09:11:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 09:11:03 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] ambition119 commented on a change in pull request #4312: [ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval Message-ID: <155834346339.1472.5243154556380346269.gitbox@gitbox.apache.org> Date: Mon, 20 May 2019 09:11:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ambition119 commented on a change in pull request #4312: [ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval URL: https://github.com/apache/pulsar/pull/4312#discussion_r285494109 ########## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java ########## @@ -337,7 +337,7 @@ ClientBuilder authentication(String authPluginClassName, Map aut * Set keep alive interval in seconds for each client-broker-connection. (default: 30). * * @param keepAliveIntervalSeconds - * @param unit time unit for {@code statsInterval} + * @param unit the time unit in which the keepAliveIntervalSeconds is defined * @return the client builder instance */ ClientBuilder keepAliveInterval(int keepAliveIntervalSeconds, TimeUnit unit); Review comment: ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services