From commits-return-29555-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon May 20 09:08:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D94E0180627 for ; Mon, 20 May 2019 11:08:00 +0200 (CEST) Received: (qmail 57084 invoked by uid 500); 20 May 2019 09:08:00 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 57075 invoked by uid 99); 20 May 2019 09:08:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2019 09:08:00 +0000 From: GitBox To: commits@pulsar.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bpulsar=5D_zymap_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=234314=3A_=60rereplicationEntryBatchSize=60_should_be_s?= =?utf-8?q?maller_than_=60maxPendingReadR=E2=80=A6?= Message-ID: <155834328009.31309.16982713327793121007.gitbox@gitbox.apache.org> Date: Mon, 20 May 2019 09:08:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zymap commented on a change in pull request #4314: `rereplicationEntryBatchSize` should be smaller than `maxPendingReadR… URL: https://github.com/apache/pulsar/pull/4314#discussion_r285492868 ########## File path: conf/bookkeeper.conf ########## @@ -224,7 +224,7 @@ maxPendingAddRequestsPerThread=10000 auditorPeriodicBookieCheckInterval=86400 # The number of entries that a replication will rereplicate in parallel. -rereplicationEntryBatchSize=5000 +rereplicationEntryBatchSize=1000 Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services