From commits-return-28703-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri May 10 15:00:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC053180763 for ; Fri, 10 May 2019 17:00:07 +0200 (CEST) Received: (qmail 56126 invoked by uid 500); 10 May 2019 15:00:07 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 56117 invoked by uid 99); 10 May 2019 15:00:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 15:00:07 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] sijie commented on a change in pull request #4255: [deploy] Provide a flag to choose the container factory to use to run functions Message-ID: <155750040730.5296.1247230434785911386.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 15:00:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #4255: [deploy] Provide a flag to choose the container factory to use to run functions URL: https://github.com/apache/pulsar/pull/4255#discussion_r282921147 ########## File path: docker/pulsar/scripts/gen-yml-from-env.py ########## @@ -75,6 +75,19 @@ conf_to_modify = conf_to_modify[key_part] modified = True i += 1 + + containerFactory=os.environ['PF_containerFactory'] Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services