From commits-return-28551-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu May 9 03:38:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 86311180630 for ; Thu, 9 May 2019 05:38:30 +0200 (CEST) Received: (qmail 29424 invoked by uid 500); 9 May 2019 03:38:30 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 29415 invoked by uid 99); 9 May 2019 03:38:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2019 03:38:29 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] shiv4289 commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer) pojo to pass config to pulsar client Message-ID: <155737310983.9138.3787132751400633576.gitbox@gitbox.apache.org> Date: Thu, 09 May 2019 03:38:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit shiv4289 commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer) pojo to pass config to pulsar client URL: https://github.com/apache/pulsar/pull/4232#discussion_r282328412 ########## File path: pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java ########## @@ -85,7 +72,7 @@ /** * {@link Producer} configuration map (will be materialized as a {@link ProducerConfigurationData} instance) */ - protected final Map producerConfig; +// protected final Map producerConfig; Review comment: Done! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services