pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #4312: [ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval
Date Tue, 21 May 2019 01:11:10 GMT
sijie commented on a change in pull request #4312: [ISSUE #4101] Fix Javadoc for ClientBuilder.keepAliveInterval
URL: https://github.com/apache/pulsar/pull/4312#discussion_r285819398
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
 ##########
 @@ -336,11 +336,11 @@ ClientBuilder authentication(String authPluginClassName, Map<String,
String> aut
     /**
      * Set keep alive interval in seconds for each client-broker-connection. <i>(default:
30)</i>.
 
 Review comment:
   remove "in seconds"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message