pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] sijie commented on a change in pull request #4255: [deploy] Provide a flag to choose the container factory to use to run functions
Date Fri, 10 May 2019 15:00:07 GMT
sijie commented on a change in pull request #4255: [deploy] Provide a flag to choose the container
factory to use to run functions
URL: https://github.com/apache/pulsar/pull/4255#discussion_r282921147
 
 

 ##########
 File path: docker/pulsar/scripts/gen-yml-from-env.py
 ##########
 @@ -75,6 +75,19 @@
                 conf_to_modify = conf_to_modify[key_part]
                 modified = True
             i += 1
+
+    containerFactory=os.environ['PF_containerFactory']
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message