pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pulsar] shiv4289 commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer) pojo to pass config to pulsar client
Date Thu, 09 May 2019 03:38:29 GMT
shiv4289 commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer)
pojo to pass config to pulsar client
URL: https://github.com/apache/pulsar/pull/4232#discussion_r282328412
 
 

 ##########
 File path: pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
 ##########
 @@ -85,7 +72,7 @@
     /**
      * {@link Producer} configuration map (will be materialized as a {@link ProducerConfigurationData}
instance)
      */
-    protected final Map<String, Object> producerConfig;
+//    protected final Map<String, Object> producerConfig;
 
 Review comment:
   Done!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message